Update broken link icon to work in FontAwesome 4 and 5 #3476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it currently is, the icon works for JupyterLab 3, but not Notebook 6. This fixes the icon to work both in Notebook 6 (FontAwesome 4) and JupyterLab 3 (FontAwesome 5).
|
|
Closed
ibdafna
approved these changes
Jun 13, 2022
|
@meeseeksdev please backport to 7.x |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
jasongrout
added a commit
to jasongrout/ipywidgets
that referenced
this pull request
Jun 22, 2022
…FontAwesome 4 and 5
|
Backported to 7.x in #3495 |
jasongrout
added a commit
that referenced
this pull request
Jun 22, 2022
Backport PR #3476: Update broken link icon to work in FontAwesome 4 and 5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3475 fixed the broken link icon for FontAwesome 5, but unfortunately things broke for FontAwesome 4 (i.e., classic Notebook). This uses CSS that works for both FontAwesome 4 and FontAwesome 5, so the broken link works in classic notebook and JupyterLab.